Attribute buffer is no longer shared, removing one RefCell.
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orium
requested review from
jongiddy,
Noah-Kennedy,
scotchmist,
kflansburg,
jasnell and
a team
as code owners
orium
commented
Aug 26, 2024
src/parser/lexer/actions.rs
Outdated
| self.current_tag_token = Some(StartTag { | ||
| name: Range::default(), | ||
| name_hash: LocalNameHash::new(), | ||
| ns: Namespace::default(), | ||
| attributes: Rc::clone(&self.attr_buffer), | ||
| attributes: Vec::with_capacity(DEFAULT_ATTR_BUFFER_CAPACITY), |
There was a problem hiding this comment.
I think we can just create the attributes here instead of reusing the buffer (which IIUC was an optimization).
orium
force-pushed
the
no-refcell-attr-buffer
branch
from
b772d3c
to
0b96dbd
Compare
orium
force-pushed
the
no-refcell-attr-buffer
branch
from
0b96dbd
to
a9dfa1c
Compare
orium
force-pushed
the
no-refcell-attr-buffer
branch
from
a9dfa1c
to
02e5a29
Compare
inikulin
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the median benchmark 3.6% slower.I'm now not pre-allocating the vector for the attributes and the median benchmark is now only 3.1% slower.