Streaming handlers #229
Open
Streaming handlers #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
requested review from
jongiddy,
Noah-Kennedy,
orium,
scotchmist,
jasnell and
a team
as code owners
kornelski
force-pushed
the
streaming-handlers
branch
2 times, most recently
from
61d1dc7
to
d5c08f9
Compare
inikulin
requested changes
Oct 29, 2024
kornelski
force-pushed
the
streaming-handlers
branch
2 times, most recently
from
8e6848b
to
7eff224
Compare
inikulin
reviewed
Nov 4, 2024
kornelski
force-pushed
the
streaming-handlers
branch
4 times, most recently
from
a6bb591
to
2408c60
Compare
kornelski
force-pushed
the
streaming-handlers
branch
from
2408c60
to
adf5554
Compare
kornelski
force-pushed
the
streaming-handlers
branch
3 times, most recently
from
85cb96a
to
212155d
Compare
kornelski
force-pushed
the
streaming-handlers
branch
from
212155d
to
fc117d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basis for cloudflare/workerd#2758
to_bytesturned into fallibleinto_bytesto guarantee that the content handlers are called only once, and to report encoding errors in the future.into_bytesusingselfbecame more performance-sensitive to the size of the token structs, so I've madeMutationsallocated lazily, assuming that majority of nodes aren't mutated.encoding_rs::Encoderwhen the output is UTF-8.