Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashbrown to v0.15.0 #236

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

antonok-edm
Copy link
Contributor

#218 describes the situation pretty well; I think a lot of downstream users would appreciate if this could be merged!

I've included a bump to criterion in this PR since it also indirectly depended on hashbrown 0.12.

Closes #218

@kornelski
Copy link
Contributor

Does criterion 0.5 support flags for you?

cargo bench -- --help

works for me with criterion 0.4, but fails to support any CLI flags with criterion 0.5.

@antonok-edm
Copy link
Contributor Author

@kornelski I've found that they had to add support for it in this PR, but that version has not been released.

In the meantime, adding this to Cargo.toml works:

clap = { version = "*", features = ["help"] }

I've just added that to this PR.

@kornelski
Copy link
Contributor

Oh, if the problem is only limited to the --help flag then that's OK. I thought all flags were broken.

@kornelski kornelski merged commit 777e8e0 into cloudflare:master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update hashbrown (Fails with latest Rust because stdsimd was deprecated)
2 participants