Skip to content

Avoid out-of-bounds panics #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Avoid out-of-bounds panics #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion moq-transport/src/serve/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ impl StreamGroupReader {
loop {
{
let state = self.state.lock();
if self.index < state.objects.len() {
if self.index < state.objects.len() - 1 {
Copy link

@Zotyamester Zotyamester Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe rearranging the inequality like if self.index + 1 < state.objects.len() { could be safer in most cases, considering that state.objects.len() can return 0.

self.index += 1;
return Ok(Some(state.objects[self.index].clone()));
}
Expand Down