Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Methods to SocketDigest for Retrieving SO_ORIGINAL_DST Information #387

Closed
wants to merge 2 commits into from
Closed

Add Methods to SocketDigest for Retrieving SO_ORIGINAL_DST Information #387

wants to merge 2 commits into from

Conversation

ermakov-oleg
Copy link
Contributor

@ermakov-oleg ermakov-oleg force-pushed the original-dst branch 2 times, most recently from 9654ab2 to 3adf53c Compare September 17, 2024 18:16
@eaufavor eaufavor added the enhancement New feature or request label Sep 19, 2024
@andrewhavck andrewhavck self-assigned this Sep 20, 2024
andrewhavck
andrewhavck requested changes Sep 20, 2024
View reviewed changes
pingora-core/src/protocols/l4/ext.rs Outdated Show resolved Hide resolved
@ermakov-oleg ermakov-oleg force-pushed the original-dst branch 4 times, most recently from f65912c to a9829f5 Compare September 20, 2024 21:22
@ermakov-oleg
Copy link
Contributor Author

@andrewhavck Builds on Rust 1.72 are failing due to the latest boring-sys release (v4.10.*), where bindgen was updated (see: cloudflare/boring#273). Any suggestions on how to resolve this or work around the issue?

@andrewhavck
Copy link
Contributor

@ermakov-oleg fix was merged so builds are passing now.

@ermakov-oleg
Copy link
Contributor Author

@andrewhavck maybe there are some other comments or something that might be blocking the merge of these changes?

@drcaramelsyrup drcaramelsyrup added the WIP We are working on this feature internally label Sep 27, 2024
@andrewhavck
Copy link
Contributor

@ermakov-oleg it's been reviewed internally, should land soon, thanks.

@andrewhavck andrewhavck added Accepted This change is accepted by us and merged to our internal repo and removed WIP We are working on this feature internally labels Sep 27, 2024
eaufavor pushed a commit that referenced this pull request Oct 11, 2024
@ermakov-oleg @andrewhavck
Add Methods to SocketDigest for Retrieving SO_ORIGINAL_DST Information
5157ff9 
---
Merge branch 'cloudflare:main' into original-dst

Co-authored-by: ermakov-oleg <ermakov-oleg@users.noreply.github.com>
Includes-commit: a3f2aff
Includes-commit: a73893b
Replicated-from: #387
eaufavor pushed a commit that referenced this pull request Oct 11, 2024
@ermakov-oleg @eaufavor
Add Methods to SocketDigest for Retrieving SO_ORIGINAL_DST Information
2a62acd 
---
Merge branch 'cloudflare:main' into original-dst

Co-authored-by: ermakov-oleg <ermakov-oleg@users.noreply.github.com>
Includes-commit: a3f2aff
Includes-commit: a73893b
Replicated-from: #387
@eaufavor
Copy link
Member

Merged and synced. Thanks!

@eaufavor eaufavor closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhavck andrewhavck andrewhavck requested changes

Assignees

@andrewhavck andrewhavck

Labels
Accepted This change is accepted by us and merged to our internal repo enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ermakov-oleg @andrewhavck @eaufavor @drcaramelsyrup