Merge pull request #2441 from cloudflare/felix/v8-128

Update to V8 12.8

.bazelrc

@@ -78,6 +78,9 @@ build:unix --host_cxxopt=-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES
 # Need to redefine _WIN32_WINNT to build dawn on Windows
 build:windows --per_file_copt='external/dawn@-Wno-macro-redefined'
 build:windows --host_per_file_copt='external/dawn@-Wno-macro-redefined'
+# V8 now requires Windows 10, Bazel fails to set this properly.
+build:windows --per_file_copt=external/v8/src/base/platform/platform-win32.cc@-D_WIN32_WINNT=0x0A00
+build:windows --host_per_file_copt=external/v8/src/base/platform/platform-win32.cc@-D_WIN32_WINNT=0x0A00
 
 # typescript configuration
 # do more correct type checking

.devcontainer/Dockerfile

@@ -2,7 +2,7 @@ FROM mcr.microsoft.com/devcontainers/base:jammy
 
 # Install dependencies, including clang via through LLVM APT repository. Note that this
 # will also install lldb and clangd alongside dependencies.
-ARG LLVM_VERSION=15
+ARG LLVM_VERSION=16
 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
     && apt-get -y install --no-install-recommends software-properties-common python3 python3-distutils tclsh \
     && curl -fSsL -o /tmp/llvm.sh https://apt.llvm.org/llvm.sh && chmod +x /tmp/llvm.sh && bash /tmp/llvm.sh ${LLVM_VERSION} \

.github/workflows/npm-types.yml

@@ -50,10 +50,10 @@ jobs:
             wget https://apt.llvm.org/llvm.sh
             sed -i '/apt-get install/d' llvm.sh
             chmod +x llvm.sh
-            sudo ./llvm.sh 15
-            sudo apt-get install -y --no-install-recommends clang-15 lld-15 libunwind-15 libc++abi1-15 libc++1-15 libc++-15-dev
-            echo "build:linux --action_env=CC=/usr/lib/llvm-15/bin/clang --action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
-            echo "build:linux --host_action_env=CC=/usr/lib/llvm-15/bin/clang --host_action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
+            sudo ./llvm.sh 16
+            sudo apt-get install -y --no-install-recommends clang-16 lld-16 libunwind-16 libc++abi1-16 libc++1-16 libc++-16-dev
+            echo "build:linux --action_env=CC=/usr/lib/llvm-16/bin/clang --action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
+            echo "build:linux --host_action_env=CC=/usr/lib/llvm-16/bin/clang --host_action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
       - name: build types
         run: |
             bazel build --disk_cache=~/bazel-disk-cache --strip=always --remote_cache=https://bazel:${{ secrets.BAZEL_CACHE_KEY }}@bazel-remote-cache.devprod.cloudflare.dev --config=release_linux //types:types

.github/workflows/npm.yml

@@ -101,10 +101,10 @@ jobs:
           wget https://apt.llvm.org/llvm.sh
           sed -i '/apt-get install/d' llvm.sh
           chmod +x llvm.sh
-          sudo ./llvm.sh 15
-          sudo apt-get install -y --no-install-recommends clang-15 lld-15 libunwind-15 libc++abi1-15 libc++1-15 libc++-15-dev
-          echo "build:linux --action_env=CC=/usr/lib/llvm-15/bin/clang --action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
-          echo "build:linux --host_action_env=CC=/usr/lib/llvm-15/bin/clang --host_action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
+          sudo ./llvm.sh 16
+          sudo apt-get install -y --no-install-recommends clang-16 lld-16 libunwind-16 libc++abi1-16 libc++1-16 libc++-16-dev
+          echo "build:linux --action_env=CC=/usr/lib/llvm-16/bin/clang --action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
+          echo "build:linux --host_action_env=CC=/usr/lib/llvm-16/bin/clang --host_action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
       - name: Build type generating Worker
         run: |
           bazel build --disk_cache=~/bazel-disk-cache --strip=always --remote_cache=https://bazel:${{ secrets.BAZEL_CACHE_KEY }}@bazel-remote-cache.devprod.cloudflare.dev --config=release_linux //types:types_worker

.github/workflows/release.yml

@@ -88,10 +88,10 @@ jobs:
           wget https://apt.llvm.org/llvm.sh
           sed -i '/apt-get install/d' llvm.sh
           chmod +x llvm.sh
-          sudo ./llvm.sh 15
-          sudo apt-get install -y --no-install-recommends clang-15 lld-15 libunwind-15 libc++abi1-15 libc++1-15 libc++-15-dev
-          echo "build:linux --action_env=CC=/usr/lib/llvm-15/bin/clang --action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
-          echo "build:linux --host_action_env=CC=/usr/lib/llvm-15/bin/clang --host_action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
+          sudo ./llvm.sh 16
+          sudo apt-get install -y --no-install-recommends clang-16 lld-16 libunwind-16 libc++abi1-16 libc++1-16 libc++-16-dev
+          echo "build:linux --action_env=CC=/usr/lib/llvm-16/bin/clang --action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
+          echo "build:linux --host_action_env=CC=/usr/lib/llvm-16/bin/clang --host_action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
       - name: Setup macOS
         if: runner.os == 'macOS'
         run: |

.github/workflows/test.yml

@@ -75,22 +75,20 @@ jobs:
         # libc++, but this appears to cause errors so they are also being explicitly installed.
         # Since the GitHub runner image comes with a number of preinstalled packages, we don't need
         # to use APT much otherwise.
-        # TODO(cleanup): Upgrade this to LLVM 16 as soon as it is available on the latest Ubuntu
-        # LTS release. Debian includes LLVM 16 since the Bookworm 12.4 point release.
         run: |
           export DEBIAN_FRONTEND=noninteractive
           wget https://apt.llvm.org/llvm.sh
           sed -i '/apt-get install/d' llvm.sh
           chmod +x llvm.sh
-          sudo ./llvm.sh 15
-          sudo apt-get install -y --no-install-recommends clang-15 lld-15 libunwind-15 libc++abi1-15 libc++1-15 libc++-15-dev libclang-rt-15-dev
-          echo "build:linux --action_env=CC=/usr/lib/llvm-15/bin/clang --action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
-          echo "build:linux --host_action_env=CC=/usr/lib/llvm-15/bin/clang --host_action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
-          sed -i -e "s%llvm-symbolizer%/usr/lib/llvm-15/bin/llvm-symbolizer%" .bazelrc
+          sudo ./llvm.sh 16
+          sudo apt-get install -y --no-install-recommends clang-16 lld-16 libunwind-16 libc++abi1-16 libc++1-16 libc++-16-dev libclang-rt-16-dev
+          echo "build:linux --action_env=CC=/usr/lib/llvm-16/bin/clang --action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
+          echo "build:linux --host_action_env=CC=/usr/lib/llvm-16/bin/clang --host_action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
+          sed -i -e "s%llvm-symbolizer%/usr/lib/llvm-16/bin/llvm-symbolizer%" .bazelrc
       - name: Setup macOS
         if: matrix.os.name == 'macOS'
         # TODO: We want to symbolize stacks for crashes on CI. Xcode is currently based on LLVM 16
-        # and the macos-13 image has llvm@15 installed:
+        # but the macos-13 image has llvm@15 installed:
         # https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md
         #
         # Not enabled because symbolication does not work on workerd macOS builds yet and running

Dockerfile.release

@@ -1,6 +1,5 @@
-# TODO(later): llvm-toolchain-16 is expected to be backported to Bullseye with the 11.9 point
-# release (https://tracker.debian.org/pkg/llvm-toolchain-16). Switch to using the regular packages
-# instead of packages from LLVM's APT repo once 11.9 is available and we have upgraded to LLVM 16.
+# TODO(later): llvm-toolchain-16 has been backported to Bullseye with the 11.9 point release –
+# switch to using the regular packages instead of LLVM's APT repo here.
 FROM node:bullseye AS builder
 
 WORKDIR /workerd
@@ -13,12 +12,12 @@ RUN wget https://apt.llvm.org/llvm.sh
 # Drop the install step here so we can install just the packages we need.
 RUN sed -i '/apt-get install/d' llvm.sh
 RUN chmod +x llvm.sh
-RUN ./llvm.sh 15
-RUN apt-get install -y --no-install-recommends clang-15 lld-15 libunwind-15 libc++abi1-15 libc++1-15 libc++-15-dev libclang-rt-15-dev
+RUN ./llvm.sh 16
+RUN apt-get install -y --no-install-recommends clang-16 lld-16 libunwind-16 libc++abi1-16 libc++1-16 libc++-16-dev libclang-rt-16-dev
 COPY . .
 
-RUN echo "build:linux --action_env=CC=/usr/lib/llvm-15/bin/clang --action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
-RUN echo "build:linux --host_action_env=CC=/usr/lib/llvm-15/bin/clang --host_action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc
+RUN echo "build:linux --action_env=CC=/usr/lib/llvm-16/bin/clang --action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
+RUN echo "build:linux --host_action_env=CC=/usr/lib/llvm-16/bin/clang --host_action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc
 COPY .bazel-cache /bazel-disk-cache
 RUN npm install -g pnpm@latest-7
 RUN pnpm install

README.md

@@ -72,11 +72,11 @@ To build `workerd`, you need:
 * [Bazel](https://bazel.build/)
   * If you use [Bazelisk](https://github.com/bazelbuild/bazelisk) (recommended), it will automatically download and use the right version of Bazel for building workerd.
 * On Linux:
-  * We use the clang/LLVM toolchain to build workerd and support version 15 and higher. Earlier versions of clang may still work, but are not officially supported.
-  * Clang 15+ (e.g. package `clang-15` on Debian Bookworm). If clang is installed as `clang-<version>` please create a symlink to it in your PATH named `clang`, or use `--action_env=CC=clang-<version>` on `bazel` command lines to specify the compiler name.
+  * We use the clang/LLVM toolchain to build workerd and support version 16 and higher. Earlier versions of clang may still work, but are not officially supported.
+  * Clang 16+ (e.g. package `clang-16` on Debian Bookworm). If clang is installed as `clang-<version>` please create a symlink to it in your PATH named `clang`, or use `--action_env=CC=clang-<version>` on `bazel` command lines to specify the compiler name.
 
-  * libc++ 15+ (e.g. packages `libc++-15-dev` and `libc++abi-15-dev`)
-  * LLD 15+ (e.g. package `lld-15`). The build may still succeed if a recent version of GNU gold or the system linker is installed, but lld is highly recommended for link performance.
+  * libc++ 16+ (e.g. packages `libc++-16-dev` and `libc++abi-16-dev`)
+  * LLD 16+ (e.g. package `lld-16`). The build may still succeed if a recent version of GNU gold or the system linker is installed, but lld is highly recommended for link performance.
   * `python3`, `python3-distutils`, and `tcl8.6`
 * On macOS:
   * Xcode 15 installation (available on macOS 13 and higher). Full Xcode is required, the Xcode command line tools alone are not sufficient for building.

WORKSPACE

@@ -214,7 +214,7 @@ http_archive(
 #   to confusing compiler errors in tcmalloc in the past.
 git_repository(
     name = "com_google_absl",
-    commit = "bfe59c2726fda7494a800f7d0ee461f0564653b3",
+    commit = "9d1552f25c3d9e9114b7d7aed55790570a99bc4d",
     remote = "https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git",
 )
 
@@ -483,26 +483,30 @@ http_archive(
         "//:patches/v8/0007-Implement-Promise-Context-Tagging.patch",
         "//:patches/v8/0008-Enable-V8-shared-linkage.patch",
         "//:patches/v8/0009-Randomize-the-initial-ExecutionContextId-used-by-the.patch",
-        "//:patches/v8/0010-Always-enable-continuation-preserved-data-in-the-bui.patch",
-        "//:patches/v8/0011-increase-visibility-of-virtual-method.patch",
-        "//:patches/v8/0012-Add-ValueSerializer-SetTreatFunctionsAsHostObjects.patch",
-        "//:patches/v8/0013-Set-torque-generator-path-to-external-v8.-This-allow.patch",
-        "//:patches/v8/0014-Modify-where-to-look-for-fp16-dependency.-This-depen.patch",
-        "//:patches/v8/0015-Expose-v8-Symbol-GetDispose.patch",
-        "//:patches/v8/0016-Rename-V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE-V8_COMPR.patch",
-        "//:patches/v8/0017-Revert-TracedReference-deref-API-removal.patch",
-        "//:patches/v8/0018-Revert-heap-Add-masm-specific-unwinding-annotations-.patch",
-        "//:patches/v8/0019-Update-illegal-invocation-error-message-in-v8.patch",
+        "//:patches/v8/0010-increase-visibility-of-virtual-method.patch",
+        "//:patches/v8/0011-Add-ValueSerializer-SetTreatFunctionsAsHostObjects.patch",
+        "//:patches/v8/0012-Set-torque-generator-path-to-external-v8.-This-allow.patch",
+        "//:patches/v8/0013-Modify-where-to-look-for-fp16-dependency.-This-depen.patch",
+        "//:patches/v8/0014-Expose-v8-Symbol-GetDispose.patch",
+        "//:patches/v8/0015-Rename-V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE-V8_COMPR.patch",
+        "//:patches/v8/0016-Revert-TracedReference-deref-API-removal.patch",
+        "//:patches/v8/0017-Revert-heap-Add-masm-specific-unwinding-annotations-.patch",
+        "//:patches/v8/0018-Update-illegal-invocation-error-message-in-v8.patch",
+        # TODO(cleanup): Patches backported from V8 12.9 – adding these fixes a race condition
+        # leading to a segfault in several wasm-related tests under ASan. These are already included
+        # in 12.9 so remove the patches when updating to that version.
+        "//:patches/v8/0019-wasm-Fix-more-code-logging-races.patch",
+        "//:patches/v8/0020-wasm-Remove-destructor-of-LogCodesTask.patch",
     ],
-    integrity = "sha256-TKEA0q6AADxlgXHIprTaw/CgQDBB6Vhug3JWlXmFKrg=",
-    strip_prefix = "v8-12.7.224.13",
-    url = "https://github.com/v8/v8/archive/refs/tags/12.7.224.13.tar.gz",
+    integrity = "sha256-yoLczQj1XEZL4EHVRjAwpVjgr9/q0YlRGnNX47Ke2ws=",
+    strip_prefix = "v8-12.8.374.10",
+    url = "https://github.com/v8/v8/archive/refs/tags/12.8.374.10.tar.gz",
 )
 
 git_repository(
     name = "com_googlesource_chromium_icu",
     build_file = "@v8//:bazel/BUILD.icu",
-    commit = "98f2494518c2dbb9c488e83e507b070ea5910e95",
+    commit = "9408c6fd4a39e6fef0e1c4077602e1c83b15f3fb",
     patch_cmds = ["find source -name BUILD.bazel | xargs rm"],
     patch_cmds_win = ["Get-ChildItem -Path source -File -Include BUILD.bazel -Recurse | Remove-Item"],
     remote = "https://chromium.googlesource.com/chromium/deps/icu.git",

compile_flags.txt

@@ -15,8 +15,8 @@
 -Iexternal/perfetto/include/perfetto/base/build_configs/bazel/
 -Iexternal/ssl/src/include
 -Isrc
--isystem/usr/lib/llvm-15/include/c++/v1
--isystem/usr/lib/llvm-15/lib/clang/15.0.7/include
+-isystem/usr/lib/llvm-16/include/c++/v1
+-isystem/usr/lib/llvm-16/lib/clang/16/include
 -isystem/usr/local/include
 -isystem/usr/include/x86_64-linux-gnu
 -isystem/usr/include

doxyfile

@@ -1219,8 +1219,8 @@ CLANG_OPTIONS          = -std=c++20     \
                          -I/usr/include/c++/11/bits \
                          -I/usr/include/x86_64-linux-gnu \
                          -I/usr/include/x86_64-linux-gnu/c++/11 \
-                         -I/usr/lib/llvm-15/include/c++/v1 \
-                         -I/usr/lib/llvm-15/lib/clang/15.0.7/include
+                         -I/usr/lib/llvm-16/include/c++/v1 \
+                         -I/usr/lib/llvm-16/lib/clang/16/include
 
 # If clang assisted parsing is enabled you can provide the clang parser with the
 # path to the directory containing a file called compile_commands.json. This

patches/v8/0001-Allow-manually-setting-ValueDeserializer-format-vers.patch

@@ -1,4 +1,4 @@
-From 9c1e267f52dfe7cd9264680452068ede59805a52 Mon Sep 17 00:00:00 2001
+From 2a878e3f5a956e375cb59e4bccd0f2fa6591d66a Mon Sep 17 00:00:00 2001
 From: Alex Robinson <arobinson@cloudflare.com>
 Date: Wed, 2 Mar 2022 15:58:04 -0600
 Subject: Allow manually setting ValueDeserializer format version
@@ -35,10 +35,10 @@ index 0cb3e045bc46ec732956318b980e749d1847d06d..40ad805c7970cc9379e69f046205836d
     * Reads raw data in various common formats to the buffer.
     * Note that integer types are read in base-128 varint format, not with a
 diff --git a/src/api/api.cc b/src/api/api.cc
-index 25ec0de2ff0b71451c64b47e83006e22813c44fa..cfb628582eda59cee9426fb8f286f8e5892b0536 100644
+index f8d3c5aa1231f4b62a614bc0c705366d922b4c75..20f02c0eee7a8f921d8e4c0ae2f06df34c22bf6f 100644
 --- a/src/api/api.cc
 +++ b/src/api/api.cc
-@@ -3570,6 +3570,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
+@@ -3599,6 +3599,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
    return private_->deserializer.GetWireFormatVersion();
  }
 
@@ -50,7 +50,7 @@ index 25ec0de2ff0b71451c64b47e83006e22813c44fa..cfb628582eda59cee9426fb8f286f8e5
    PREPARE_FOR_EXECUTION(context, ValueDeserializer, ReadValue);
    i::MaybeHandle<i::Object> result;
 diff --git a/src/objects/value-serializer.h b/src/objects/value-serializer.h
-index 0d38d4a0e0421f449629ab7fb0f2ac6a0093e59b..4e1fbcb160f7f89740a490ddbc448bce2ae6e3a3 100644
+index 094210f286ab107f93b4a0e1529210a5328e0df0..8ec0a77210dda063a8c64d3c52b3209a8194827b 100644
 --- a/src/objects/value-serializer.h
 +++ b/src/objects/value-serializer.h
 @@ -218,6 +218,13 @@ class ValueDeserializer {

patches/v8/0002-Allow-manually-setting-ValueSerializer-format-versio.patch

@@ -1,4 +1,4 @@
-From 3253a1204a2c8403ae3d6ed74099275d0ade9541 Mon Sep 17 00:00:00 2001
+From 89b24ba580034518e735c60838819c062b985c11 Mon Sep 17 00:00:00 2001
 From: James M Snell <jasnell@gmail.com>
 Date: Wed, 16 Mar 2022 08:59:21 -0700
 Subject: Allow manually setting ValueSerializer format version
@@ -22,10 +22,10 @@ index 40ad805c7970cc9379e69f046205836dbd760373..596be18adeb3a5a81794aaa44b1d347d
     * Writes out a header, which includes the format version.
     */
 diff --git a/src/api/api.cc b/src/api/api.cc
-index cfb628582eda59cee9426fb8f286f8e5892b0536..e2c3f310a8d85823e5873d3682122eec8f3d441c 100644
+index 20f02c0eee7a8f921d8e4c0ae2f06df34c22bf6f..404d19e8c5cf4b4505fb9106f0b649b44708e729 100644
 --- a/src/api/api.cc
 +++ b/src/api/api.cc
-@@ -3438,6 +3438,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
+@@ -3467,6 +3467,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
 
  ValueSerializer::~ValueSerializer() { delete private_; }
 
@@ -37,7 +37,7 @@ index cfb628582eda59cee9426fb8f286f8e5892b0536..e2c3f310a8d85823e5873d3682122eec
 
  void ValueSerializer::SetTreatArrayBufferViewsAsHostObjects(bool mode) {
 diff --git a/src/objects/value-serializer.cc b/src/objects/value-serializer.cc
-index 3c6ed8f827a126701b212526f9603832ddb2bce8..2e574704650c3b5d860fc21d083e9e6fed9ddfcf 100644
+index e606ad4f8da446c0edb1b2696eec9701b166719a..96ad656a42173b66974539472467c497b89dc587 100644
 --- a/src/objects/value-serializer.cc
 +++ b/src/objects/value-serializer.cc
 @@ -291,6 +291,7 @@ ValueSerializer::ValueSerializer(Isolate* isolate,
@@ -67,7 +67,7 @@ index 3c6ed8f827a126701b212526f9603832ddb2bce8..2e574704650c3b5d860fc21d083e9e6f
  }
 
  void ValueSerializer::SetTreatArrayBufferViewsAsHostObjects(bool mode) {
-@@ -1034,10 +1043,12 @@ Maybe<bool> ValueSerializer::WriteJSArrayBufferView(
+@@ -1033,10 +1042,12 @@ Maybe<bool> ValueSerializer::WriteJSArrayBufferView(
    WriteVarint(static_cast<uint8_t>(tag));
    WriteVarint(static_cast<uint32_t>(view->byte_offset()));
    WriteVarint(static_cast<uint32_t>(view->byte_length()));
@@ -83,7 +83,7 @@ index 3c6ed8f827a126701b212526f9603832ddb2bce8..2e574704650c3b5d860fc21d083e9e6f
  }
 
 diff --git a/src/objects/value-serializer.h b/src/objects/value-serializer.h
-index 4e1fbcb160f7f89740a490ddbc448bce2ae6e3a3..c3a44e9f64f944641eea417584429a0b147ef654 100644
+index 8ec0a77210dda063a8c64d3c52b3209a8194827b..27d5d03518e7bfecde240b658f63456c899f378c 100644
 --- a/src/objects/value-serializer.h
 +++ b/src/objects/value-serializer.h
 @@ -54,6 +54,11 @@ class ValueSerializer {