Skip to content

Commit

Permalink
[CI] Set right architecture for x64 macOS release artifact
Browse files Browse the repository at this point in the history
This is needed now that we cross-compile from an Apple Silicon image.
  • Loading branch information
fhanau committed Nov 7, 2024
1 parent 20d994e commit 7330750
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,17 @@ jobs:
- os-name: linux
os: ubuntu-20.04
bazel-config: release_linux
target-arch: X64
- os-name: macOS
# This configuration is used for cross-compiling – macos-15 is Apple Silicon-based but
# we use it to compile the x64 release.
os: macos-15
bazel-config: release_macos
target-arch: X64
- os-name: windows
os: windows-2022
bazel-config: release_windows
target-arch: X64
runs-on: ${{ matrix.os }}
name: build (${{ matrix.os-name }})
steps:
Expand Down Expand Up @@ -126,7 +131,7 @@ jobs:
- name: Upload binary
uses: actions/upload-artifact@v4
with:
name: ${{ runner.os }}-${{ runner.arch }}-binary
name: ${{ runner.os }}-${{ matrix.target-arch }}-binary
path: bazel-bin/src/workerd/server/workerd${{ runner.os == 'Windows' && '.exe' || '' }}

upload-artifacts:
Expand Down

0 comments on commit 7330750

Please sign in to comment.