Skip to content

Commit

Permalink
[nfc] always download outputs in release builds (#3077)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikea authored Nov 7, 2024
1 parent 1301bb4 commit bcd5c87
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,14 @@ jobs:
image: ${{ matrix.os.image }}
os_name: ${{ matrix.os.name }}
suffix: ${{ matrix.config.suffix }}
extra_bazel_args: "--config=ci-test"
secrets:
BAZEL_CACHE_KEY: ${{ secrets.BAZEL_CACHE_KEY }}
WORKERS_MIRROR_URL: ${{ secrets.WORKERS_MIRROR_URL }}
lint:
uses: ./.github/workflows/_bazel.yml
with:
extra_bazel_args: "--config=lint"
extra_bazel_args: "--config=lint --config=ci-test"
run_tests: false
secrets:
BAZEL_CACHE_KEY: ${{ secrets.BAZEL_CACHE_KEY }}
Expand Down
5 changes: 4 additions & 1 deletion build/ci.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@ build:ci --color=yes
build:ci --terminal_columns=100

build:ci --config=v8-codegen-opt
build:ci --remote_download_minimal --disk_cache=~/bazel-disk-cache
test:ci --test_output=errors
build:ci --disk_cache=~/bazel-disk-cache

# test CI jobs don't need any top-level artifacts and just verify things
build:ci-test --remote_download_outputs=minimal

# limit storage usage on ci
# Exclude large benchmarking binaries created in debug and asan configurations to avoid
Expand Down

0 comments on commit bcd5c87

Please sign in to comment.