fix invalid url parsing memory leak (#2159)

cloudflare · May 24, 2024 · e8ecf09 · e8ecf09
1 parent 0ff3e54
commit e8ecf09
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/workerd/jsg/url.c++ b/src/workerd/jsg/url.c++
@@ -161,7 +161,10 @@ kj::Maybe<Url> Url::tryParse(kj::ArrayPtr<const char> input,
   } else {
     result = ada_parse(input.begin(), input.size());
   }
-  if (!ada_is_valid(result)) return kj::none;
+  if (!ada_is_valid(result)) {
+    ada_free(result);
+    return kj::none;
+  }
   return Url(wrap(result));
 }