Add gha to upload Pyodide javascript bundle to R2 #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
5 times, most recently
from
b9d9440
to
9699f70
Compare
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
7 times, most recently
from
b8fd99a
to
146638c
Compare
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
3 times, most recently
from
c509902
to
592059f
Compare
hoodmane
changed the title
hoodmane
changed the title
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
from
592059f
to
7f3d33d
Compare
Should I wait for this to be done before reviewing? |
|
Perhaps. We probably don't need to even merge this since this action is intended to go into pyodide-build-scripts eventually. |
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
2 times, most recently
from
20f32c0
to
a56f673
Compare
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
3 times, most recently
from
59488e5
to
7d1c044
Compare
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
5 times, most recently
from
3682e8d
to
0f494a9
Compare
hoodmane
changed the title
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
3 times, most recently
from
5e2a8ec
to
d559d35
Compare
dom96
approved these changes
Oct 28, 2024
|
Yeah, eventually. We might as well merge this as-is and when we move repos we'll have to update how everything works. |
danlapid
reviewed
Oct 28, 2024
danlapid
reviewed
Oct 28, 2024
danlapid
reviewed
Oct 28, 2024
danlapid
reviewed
Oct 28, 2024
danlapid
reviewed
Oct 28, 2024
| chmod +x llvm.sh | ||
| sudo ./llvm.sh 15 | ||
| sudo apt-get install -y --no-install-recommends clang-15 lld-15 libunwind-15 libc++abi1-15 libc++1-15 libc++-15-dev | ||
| echo "build:linux --action_env=CC=/usr/lib/llvm-15/bin/clang --action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc |
There was a problem hiding this comment.
Suggested change
| echo "build:linux --action_env=CC=/usr/lib/llvm-15/bin/clang --action_env=CXX=/usr/lib/llvm-15/bin/clang++" >> .bazelrc | |
| echo "build:linux --action_env=CC=/usr/lib/llvm-16/bin/clang --action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc |
danlapid
reviewed
Oct 28, 2024
|
LGTM just a bit outdated since this PR was opened, let's update and merge |
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
from
d559d35
to
f5f2143
Compare
This adds a github action that makes the Pyodide capnproto binary bundle and uploads it to r2.
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
from
f5f2143
to
5f8816c
Compare
danlapid
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a github action that makes the Pyodide capnproto binary bundle and
uploads it to r2.