more user-friendly jsg exception message #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strictly speaking this is not backward compatible, but I doubt anyone cares and it has saved me some time while debugging an issue.
anonrig
approved these changes
Aug 14, 2024
jasnell
reviewed
Aug 14, 2024
| @@ -103,8 +103,9 @@ class StructWrapper<Self, T, TypeTuple<FieldWrappers...>, kj::_::Indexes<indices | |||
| kj::isSameType<typename FieldWrappers::Type, Unimplemented>()) && ...)) { | |||
| return T{}; | |||
| } | |||
| jsg::throwTypeError(isolate, "Cannot initialize a dictionary with required members from an " | |||
| "undefined or null value."); | |||
| jsg::throwTypeError(isolate, kj::str("Cannot initialize ", typeid(T).name(), | |||
There was a problem hiding this comment.
minor nit but is this going to give a user friendly name that is useful for end users or something only we can appreciate?
There was a problem hiding this comment.
Friendliness is debatable, but this is definitely something that will have a name similar to TS type.
jasnell
approved these changes
Aug 14, 2024
npaun
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strictly speaking this is not backward compatible, but I doubt anyone cares and it has saved me some time while debugging an issue.