-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update prettier and clang-format cli options in format.py #2576
Conversation
Is this for taste or performance? |
If it's just to cut down on noise I think --check + --log-level=warn will look nicer than --list-different? |
Mostly for taste. I don't have My local benchmarks using |
I agree with @anonrig that we should get rid of |
+1 to going with the less verbose output |
793a098
to
6964ab8
Compare
6964ab8
to
57da4c0
Compare
Would you mind reviewing this pull-request? |
57da4c0
to
ca2ebac
Compare
ca2ebac
to
6a0a805
Compare
6a0a805
to
9a23413
Compare
--check
with--list-different
to reduce noise (hides the files that does not need formatting)--log-level=warn
on formatting where now it prints only the files that actually changed.