Expose zlib constants directly under zlib module #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Sep 27, 2024
| @@ -100,12 +213,122 @@ export { | |||
| brotliDecompressSync, | |||
| brotliCompress, | |||
| brotliCompressSync, | |||
|
|
|||
| // NodeJS also exports all constants directly under zlib, but this is deprecated | |||
There was a problem hiding this comment.
@jasnell afaik, there isn't any other alternative way to expose this, but any idea?
There was a problem hiding this comment.
Well... you could move all of the constants here into a separate internal/zlib-constants import as named exports only... then do
import * as zlibConstants from 'node-internal:zlib-constants';
export const constants = { ...zlibConstants };
export * from 'node-internal:zlib-constants';But might not be worth the extra hassle. I'd just go with this for now.
There was a problem hiding this comment.
JavaScript is a weird language.
jasnell
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supported in NodeJS but is deprecated.
Fixes #2805