Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move thenables to coroutines on worker-interface #2873

Closed
wants to merge 1 commit into from
Closed

move thenables to coroutines on worker-interface #2873

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 9, 2024

Saw an internal initiative that was abandoned, which moves several .then and .catch statements to coroutines. Let's make a small change on worker-interface.c++

@anonrig anonrig requested review from a team as code owners October 9, 2024 15:04
@anonrig
Copy link
Member Author

anonrig commented Oct 14, 2024

Breaking downstream.

@anonrig anonrig closed this Oct 14, 2024
@anonrig anonrig deleted the yagiz/coroutines-worker-interface branch October 14, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npaun npaun npaun approved these changes

@jasnell jasnell jasnell approved these changes

@garrettgu10 garrettgu10 Awaiting requested review from garrettgu10 garrettgu10 is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
needs-internal-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anonrig @jasnell @npaun