Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPT: Replace invalid characters in test names #3036

Merged
merged 1 commit into from
Oct 31, 2024
Merged

WPT: Replace invalid characters in test names #3036

merged 1 commit into from
Oct 31, 2024

Conversation

npaun
Copy link
Member

@npaun npaun commented Oct 31, 2024

Remember kids, just say no to byte-order marks and surrogate pairs.

@npaun npaun requested review from a team as code owners October 31, 2024 14:11
danlapid
danlapid approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get an internal PR passing just to be sure

@npaun
Copy link
Member Author

npaun commented Oct 31, 2024

Internal PR passes

@npaun npaun merged commit 7e3e636 into main Oct 31, 2024
14 of 15 checks passed
@npaun npaun deleted the npaun/wpt-bom branch October 31, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlapid danlapid danlapid approved these changes

@jasnell jasnell jasnell approved these changes

@fhanau fhanau Awaiting requested review from fhanau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npaun @jasnell @danlapid