Add LazyWorkerInterface #3038
Merged
Add LazyWorkerInterface #3038
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
Nov 2, 2024
danlapid
force-pushed
the
dlapid/sharding_newLoopback
branch
from
5bdfd45
to
7e7b195
Compare
This is a new WorkerInterface class that will be used in the internal PR, see comments to understand what it does.
danlapid
force-pushed
the
dlapid/sharding_newLoopback
branch
from
7e7b195
to
2c56853
Compare
jasnell
reviewed
Nov 5, 2024
| template <typename Func> | ||
| class LazyWorkerInterface final: public WorkerInterface { | ||
| public: | ||
| LazyWorkerInterface(Func func): func(kj::mv(func)) {} |
There was a problem hiding this comment.
Non-blocking nit: might consider marking this explicitly KJ_DISALLOW_COPY_AND_MOVE but not critical with having the KJ_ASSERT_NONNULLs
There was a problem hiding this comment.
Yea copies would be bad but they are implicitly disabled by virtue of having an Own member.
I don't see why moves should be a problem.
There was a problem hiding this comment.
Largely just an explicit hygiene thing for me... kind of a safeguard against someone changing any of the methods later and forgetting a KJ_ASSERT_NONNULL. But I'm being a bit extra paranoid :-)
jasnell
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new WorkerInterface class that will be used in the internal PR, see comments to understand what it does.