Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format.py: Use bazel build, support excludes #3062

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

npaun
Copy link
Member

@npaun npaun commented Nov 5, 2024

Adds a few features to format.py that improve compatibility with the internal repo:

  • Adds excludes to the config, listing directories that should not be formatted
  • Uses bazel build instead of bazel fetch, so that bazel creates some symlinks the internal repo expects to exist.
  • Fixes a mistake in the filegroup config for formatters distributed as a http_archive

@npaun npaun requested review from fhanau and danlapid November 5, 2024 17:49
@npaun npaun requested review from a team as code owners November 5, 2024 17:49
@npaun npaun merged commit b2c31bd into main Nov 5, 2024
13 checks passed
@npaun npaun deleted the npaun/formatpy-extras branch November 5, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants