Add updateConfiguration function to jsg Isolates #3065
+40
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
force-pushed
the
dlapid/update_jsg_configuration
branch
from
a86082d
to
3a697f2
Compare
This can be used to update the given configuration at runtime. Note that while some jsg structs are lazily using the configuration, others can use it at construction and will have the original configuration value.
danlapid
force-pushed
the
dlapid/update_jsg_configuration
branch
from
3a697f2
to
23172a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to update the given configuration at runtime.
Note that while some jsg structs are lazily using the configuration, others can use it at construction and will have the original configuration value.
This is another step towards Python Isolate Pools and is coming in direct continuation to #2999.
This is another part split from workerd #2936 and internal #9006 for reviewability.