Export setupContext publically to be used by additional contexts. #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
requested review from
harrishancock,
mar-cf,
dom96,
jasnell and
hoodmane
danlapid
commented
Nov 6, 2024
| @@ -599,40 +596,12 @@ struct Worker::Isolate::Impl { | |||
| KJ_DISALLOW_COPY_AND_MOVE(Lock); | |||
|
|
|||
| void setupContext(v8::Local<v8::Context> context) { | |||
| // Set WebAssembly.Module @@HasInstance | |||
| setWebAssemblyModuleHasInstance(*lock, context); | |||
|
|
|||
| // The V8Inspector implements the `console` object. | |||
| KJ_IF_SOME(i, impl.inspector) { | |||
There was a problem hiding this comment.
Only real change is that Set WebAssembly.Module @@HasInstance is now only set after alerting the inspector of a new context.
This shouldn't have any actual effect in practice.
dom96
approved these changes
Nov 6, 2024
jasnell
approved these changes
Nov 6, 2024
danlapid
force-pushed
the
dlapid/export_worker_setup_context
branch
from
14c3279
to
77a3124
Compare
Currently Worker::Isolate::Impl does the setup of the context. Namely setting up the console and WebAssembly.Module@@HasInstance. This functionallity is useful in general to any context we might create even before we have a Worker::Isolate. This commit moves this functionallity to a publically facing api.
danlapid
force-pushed
the
dlapid/export_worker_setup_context
branch
from
77a3124
to
22652a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Worker::Isolate::Impl does the setup of the context. Namely setting up the console and WebAssembly.Module@@HasInstance. This functionality is useful in general to any context we might create even before we have a Worker::Isolate.
This commit moves this functionality to a publicly facing api.
Another part split from #2936