[CI] Set right architecture for x64 macOS release artifact #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed now that we cross-compile from an Apple Silicon image.
fhanau
commented
Nov 7, 2024
| @@ -61,12 +61,17 @@ jobs: | |||
| - os-name: linux | |||
| os: ubuntu-20.04 | |||
| bazel-config: release_linux | |||
| target-arch: X64 | |||
There was a problem hiding this comment.
This is redundant at present (all releases built on GitHub Actions are for x86), but I plan to build the Apple Silicon release here too some time after #3079 has landed. Open to alternative suggestions.
There was a problem hiding this comment.
👍
Merged and seems to work correctly now, thanks for approving!
npaun
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed now that we cross-compile from an Apple Silicon image.
=============
The problem here is that with #3078 the x64 macOS release artifact continues to be a valid x64 binary, but is uploaded as
macOS-ARM64-binary, which prevents it from being added to tagged releases.