-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import unenv-preset #7370
import unenv-preset #7370
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while personally recommand unbuild/mkdist, also a simple tsc would work if it is widely used in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any other convention perhaps here?
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-wrangler-7370 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7370/npm-package-wrangler-7370 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-wrangler-7370 dev path/to/script.js Additional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-cloudflare-workers-bindings-extension-7370 -O ./cloudflare-workers-bindings-extension.0.0.0-v5995bd3c6.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v5995bd3c6.vsix npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-create-cloudflare-7370 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-cloudflare-kv-asset-handler-7370 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-miniflare-7370 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-cloudflare-pages-shared-7370 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-cloudflare-unenv-preset-7370 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-cloudflare-vitest-pool-workers-7370 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-cloudflare-workers-editor-shared-7370 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-cloudflare-workers-shared-7370 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12371005027/npm-package-cloudflare-workflows-shared-7370 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
08eea47
to
708af56
Compare
0195bfd
to
81019e0
Compare
packages/unenv-preset/src/runtime/node/async_hooks/$cloudflare.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to update findPackageNames()
in validate-changesets.test.ts
.
Still need to fix this test:
|
And appears to be a problem with the lockfile? |
I think to do the first deployment we need to mark it as public access: npm publish --access public |
57e875b
to
813d437
Compare
d3bd9bf
to
5f59687
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this one small nit.
sync at unjs/unenv d9d4d03 https://github.com/pi0/unenv-preset-cloudflare Co-authored-by: Pooya Parsa <pooya@pi0.io> step step step
feat(unenv-preset): import the package sync at unjs/unenv 7e05819 https://github.com/pi0/unenv-preset-cloudflare Co-authored-by: Pooya Parsa <pooya@pi0.io>
@pi0 @petebacondarwin This PR imports & sync the cloudflare preset.
#7366 lists (most of) the tasks that will need to be done.
--
Smoke tested with https://github.com/cloudflare/workers-sdk/tree/preset-test. In that branche, wrangler uses
@cloudflare/unenv-preset
and the hybrid test pass.Next steps:
--
@pi0 I changed the license to MIT + Apache, is that ok with you?
@petebacondarwin do you think it would cause an issue to merge this before all of #7366 is done?