Skip to content

Bumps create-hono now that upstream has updated to use wrangler.json #7972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

andyjessop
Copy link
Contributor

Fixes #7905

create-hono has now been updated to generate wrangler.json instead of wrangler.toml. Because create-hono points to main on the starter instead of a specific version, we need to bump it to ensure the two are in-sync.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal only

remove fixture
@andyjessop andyjessop requested review from a team as code owners January 30, 2025 13:40
Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: 6abc41d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andyjessop andyjessop added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-wrangler-7972

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7972/npm-package-wrangler-7972

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-wrangler-7972 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-cloudflare-workers-bindings-extension-7972 -O ./cloudflare-workers-bindings-extension.0.0.0-v27b970266.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v27b970266.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-create-cloudflare-7972 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-cloudflare-kv-asset-handler-7972

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-miniflare-7972

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-cloudflare-pages-shared-7972

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-cloudflare-unenv-preset-7972

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-cloudflare-vite-plugin-7972

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-cloudflare-vitest-pool-workers-7972

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-cloudflare-workers-editor-shared-7972

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-cloudflare-workers-shared-7972

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13053869633/npm-package-cloudflare-workflows-shared-7972

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.106.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@andyjessop andyjessop merged commit 7112347 into main Jan 30, 2025
30 checks passed
@andyjessop andyjessop deleted the aj/bump-hono branch January 30, 2025 14:38
@edmundhung edmundhung mentioned this pull request Jan 30, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 BUG: New Hono project from C3 creates wrangler.toml and wrangler.json
3 participants