Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change tag type List of DictType to DictType and etc #18

Merged
merged 4 commits into from
Oct 18, 2022
Merged

fix: change tag type List of DictType to DictType and etc #18

merged 4 commits into from
Oct 18, 2022

Conversation

ImMin5
Copy link
Member

@ImMin5 ImMin5 commented Oct 18, 2022 •
edited
Loading

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • change tag type List of DictType to DictType
    • changed our tag spec
  • remove duplicate code in sql_servers's manager
    1. collect SQL Servers in console
    2. see log in SpaceONE history menu
    3. you can see sql_database collected two times
      스크린샷 2022-10-17 오전 11 21 01

Known issue

@ImMin5 ImMin5 added bug Something isn't working enhancement New feature or request labels Oct 18, 2022
@ImMin5 ImMin5 self-assigned this Oct 18, 2022
@ImMin5
fix: update cloud_service.py
8d0e4c2 
* fix: update cloud_service.py

* fix: fix typo
jihyungSong
jihyungSong approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@jihyungSong jihyungSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good to see.
Approve it.

@jihyungSong jihyungSong merged commit efb6f66 into cloudforet-io:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihyungSong jihyungSong jihyungSong approved these changes

Assignees

@ImMin5 ImMin5

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImMin5 @jihyungSong