Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infrastructure): Bring multiapps-controller to CF #2988

Merged
merged 54 commits into from
Aug 9, 2024

Conversation

bonzofenix
Copy link
Contributor

@bonzofenix bonzofenix commented Jun 5, 2024

Motivation

To move autoscaler components into cf for production consumption we need to relay on a app lifecycle solution for autoscaler as a whole.

As a first step we need to set up the multi apps controller in the OSS infrastructure, which has a dependency on a DB solution such as the Postgres DB service.

@bonzofenix bonzofenix self-assigned this Jun 5, 2024
@bonzofenix bonzofenix changed the title Initial commit feat(infrastructure): Enable mtar controller in infrastructure Jun 5, 2024
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
@bonzofenix bonzofenix force-pushed the feature/739-setup-mtar-controller branch from d69e68e to 3d7bfca Compare June 7, 2024 10:10
@bonzofenix bonzofenix added the 🚧🛠️ WIP📝 Work in progress label Jun 7, 2024
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
@bonzofenix bonzofenix force-pushed the feature/739-setup-mtar-controller branch 4 times, most recently from 92b44f3 to 3a8cfef Compare June 7, 2024 10:47
@bonzofenix bonzofenix force-pushed the feature/739-setup-mtar-controller branch from 123b53b to 20cb27a Compare June 7, 2024 10:53
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/utils.source.sh Outdated Show resolved Hide resolved
@bonzofenix bonzofenix force-pushed the feature/739-setup-mtar-controller branch from 20cb27a to 510b180 Compare June 7, 2024 12:22
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/scripts/trigger-job.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
ci/infrastructure/scripts/deploy-postgres.sh Outdated Show resolved Hide resolved
@bonzofenix bonzofenix force-pushed the feature/739-setup-mtar-controller branch from e2fe4ea to e416935 Compare June 7, 2024 16:00
@bonzofenix bonzofenix force-pushed the feature/739-setup-mtar-controller branch 7 times, most recently from 88a853e to 77e93bc Compare June 10, 2024 10:46
@bonzofenix bonzofenix added allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. and removed 🚧🛠️ WIP📝 Work in progress labels Aug 8, 2024
@bonzofenix bonzofenix force-pushed the feature/739-setup-mtar-controller branch from 2bb85c1 to b09dacf Compare August 8, 2024 15:02
@bonzofenix bonzofenix force-pushed the feature/739-setup-mtar-controller branch from f0381c2 to 3145d06 Compare August 8, 2024 15:11
Copy link

sonarcloud bot commented Aug 9, 2024

Copy link
Contributor

@geigerj0 geigerj0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the changes I've added https://github.com/cloudfoundry/app-autoscaler-release/pull/2988/files/06211c4b32b2ede7af2f65c7c4b28ef53b851d0e..bb445946f78f0dd7464f5c0b6f1124f8c53e52b8

I also cleaned up CF and deleted the postgres bosh deployment. After I've cleaned up everything, the deploy-multiapps-controller concourse job ran successfully 🟢

Let's bring this in and start harvesting the fruits of the deploy-service 🧑‍🌾

Copy link
Contributor Author

@bonzofenix bonzofenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geigerj0 geigerj0 added allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. and removed allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. labels Aug 9, 2024
@geigerj0 geigerj0 disabled auto-merge August 9, 2024 11:49
@geigerj0 geigerj0 enabled auto-merge (squash) August 9, 2024 11:52
@geigerj0 geigerj0 disabled auto-merge August 9, 2024 11:52
@geigerj0 geigerj0 enabled auto-merge (squash) August 9, 2024 11:53
@geigerj0 geigerj0 merged commit 11bd8b3 into main Aug 9, 2024
33 of 39 checks passed
@geigerj0 geigerj0 deleted the feature/739-setup-mtar-controller branch August 9, 2024 11:53
joergdw pushed a commit that referenced this pull request Aug 16, 2024
Co-authored-by: Silvestre Zabala <silvestre.zabala@sap.com>
Co-authored-by: geigerj0 <112163019+geigerj0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. exclude-from-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants