Remove PR_NUMBER check from build-extension-file.sh in autoscaler module #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for the PR number is not necessary, when PR number is not present the default port of 5432 will be assign to the autoscaler tcp route. Removing this check would allow the pipeline to run for the concourse branch in main.
|
bonzofenix
added
the
allow-acceptance-tests
asalan316
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipeline is currently failing:
https://concourse.app-runtime-interfaces.ci.cloudfoundry.org/teams/app-autoscaler/pipelines/app-autoscaler-release/jobs/acceptance-log-cache-syslog-cf/builds/118
The PR number in the build extension file is not required, default port 5432 will be assigned to the autoscaler Postgres TCP route when not available.
Removing this check would allow the pipeline to run for the concourse branch in main and for PRs