Add acceptance tests for cnb lifecycle #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Nicolas Bender <nicolas.bender@sap.com>
Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com>
ctlong
requested changes
Jun 1, 2024
Co-authored-by: Johannes Dillmann <j.dillmann@sap.com>
ctlong
approved these changes
Jun 4, 2024
1 task
mariash
reviewed
Jul 15, 2024
| @@ -157,6 +160,8 @@ func getDefaults() config { | |||
| defaults.RubyBuildpackName = ptrToString("ruby_buildpack") | |||
| defaults.StaticFileBuildpackName = ptrToString("staticfile_buildpack") | |||
|
|
|||
| defaults.CNBNodejsBuildpackName = ptrToString("docker://gcr.io/paketo-buildpacks/nodejs:latest") | |||
There was a problem hiding this comment.
would this cause test flakiness when there are network issues?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
All PR's to CATs should be submitted to develop and will be merged to main once they've passed acceptance.
What is this change about?
Describe the change and why it's needed.
Added acceptance tests using the new cloud native buildpack lifecycle.
Please provide contextual information.
Include any links to other PRs, stories, slack discussions, etc... that will help establish context.
What version of cf-deployment have you run this cf-acceptance-test change against?
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.
Same as for docker or buildpacks lifecycle. It is some basic functionality added to
cf.How many more (or fewer) seconds of runtime will this change introduce to CATs?
~ 70s
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.
@loewenstein-sap, @modulo11, @pbusko, @nicolasbender