Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing unit test for fips-compliance ops file #1159

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add missing unit test for fips-compliance ops file #1159

merged 1 commit into from
Jan 22, 2024

Conversation

jochenehret
Copy link
Contributor

WHAT is this change about?

Add unit test for fips-compliance.yml ops file.

What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...

Alana wants all ops files to be tested.

Please provide any contextual information.

#1158

Has a cf-deployment including this change passed cf-acceptance-tests?

  • YES
  • NO

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

How should this change be described in cf-deployment release notes?

Not relevant.

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

Please provide Acceptance Criteria for this change?

Unit test job must succeed: https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/cf-deployment/jobs/unit-test-golang-tests

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

@jochenehret jochenehret requested review from a team January 22, 2024 11:43
@jochenehret jochenehret merged commit fc505f1 into develop Jan 22, 2024
2 checks passed
@jochenehret jochenehret deleted the fips_ops_unit_test branch January 22, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippthun philippthun philippthun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jochenehret @philippthun