Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fips-compliance ops file for FIPS validation #1163

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Use fips-compliance ops file for FIPS validation #1163

merged 1 commit into from
Jan 26, 2024

Conversation

jochenehret
Copy link
Contributor

WHAT is this change about?

Use the new fips-compliance ops file for the FIPS validation: https://github.com/cloudfoundry/cf-deployment/blob/develop/operations/experimental/fips-compliance.yml

Remove the "try" block for the smoke tests. They have turned green and now we want to make regressions visible in the Concourse pipeline.

What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...

Alana wants a FIPS-compliant cf-deployment.

Please provide any contextual information.

#1140

Has a cf-deployment including this change passed cf-acceptance-tests?

  • YES
  • NO

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

How should this change be described in cf-deployment release notes?

N/A

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

Please provide Acceptance Criteria for this change?

FIPS validation pipeline stays green: https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/fips-stemcell

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

@jochenehret
Use fips-compliance ops file for FIPS validation
4114617 
* and remove the "try" block for the smoke tests as they have turned green now
@jochenehret jochenehret requested a review from a team January 26, 2024 11:42
@jochenehret jochenehret merged commit 0ca6187 into develop Jan 26, 2024
3 checks passed
@jochenehret jochenehret deleted the use_fips_compliance_ops_file branch January 26, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippthun philippthun philippthun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jochenehret @philippthun