Fix failing unit test timezone bug [v8] #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weresch
force-pushed
the
unit-test-timezone-bug
branch
2 times, most recently
from
791f872
to
6076f9c
Compare
Co-authored-by: George Gelashvili <george.gelashvili@broadcom.com>
weresch
force-pushed
the
unit-test-timezone-bug
branch
from
6076f9c
to
4d85773
Compare
a-b
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Some unit tests that were checking timezones were getting inconsistent results on GitHub runners. Updated the tests to validate the shape of the date and time instead.