Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null canary object #3435

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Fix null canary object #3435

merged 1 commit into from
Mar 4, 2025

Conversation

Samze
Copy link
Contributor

@Samze Samze commented Feb 28, 2025

v8 version of #3433

Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Do not send null canary object if no steps have been specified
@Samze Samze force-pushed the fix_canary_object_v8_branch branch from d4c8fa7 to 0d1de6d Compare March 3, 2025 21:39
@Samze Samze merged commit e10661b into v8 Mar 4, 2025
20 checks passed
@Samze Samze deleted the fix_canary_object_v8_branch branch March 4, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants