[main] Improve integration test flakiness around servicebroker tests #3648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ensureAppIsDeployed helper was calling appResponds() immediately and passing the result (a boolean) to Eventually. This prevented Gomega from polling the function, causing failures if the app wasn't ready instantly. This change passes the function reference appResponds to Eventually so it can be polled correctly, and adds a 1-minute timeout to allow for slower environments.
anujc25
changed the title
prkalle
reviewed
Dec 1, 2025
Contributor
prkalle
left a comment
prkalle
left a comment
There was a problem hiding this comment.
LGTM.
Good to go once the CI pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix intermittent integration test failures around servicebroker
Why Is This PR Valuable?
Improves integration test reliability
Applicable Issues
None
How Urgent Is The Change?
Not urgent