Refactoring UAA client

[philippthun]

While working on the "Support UAA identity zones in CC" PoC [1], I did some refactoring that I would like to keep although the PoC is not going to get implemented (see [2]).

[1] #3341
[2] cloudfoundry/uaa#2505

• I have reviewed the contributing guide

• I have viewed, signed, and submitted the Contributor License Agreement

• I have made this pull request to the main branch

• I have run all the unit tests using bundle exec rake

• I have run CF Acceptance Tests

[kathap]

I can see use of uaa_client in

cloud_controller_ng/spec/unit/collection_transformers/username_populator_spec.rb

Line 6 in b2464ff

let(:username_populator) { UsernamePopulator.new(uaa_client) }

and

cloud_controller_ng/spec/unit/collection_transformers/usernames_and_roles_populator_spec.rb

Line 6 in b2464ff

let(:username_populator) { UsernamesAndRolesPopulator.new(uaa_client) }

maybe there it should also be uaa_username_lookup_client

[philippthun]

I can see use of uaa_client in

cloud_controller_ng/spec/unit/collection_transformers/username_populator_spec.rb

Line 6 in b2464ff

let(:username_populator) { UsernamePopulator.new(uaa_client) }

and

cloud_controller_ng/spec/unit/collection_transformers/usernames_and_roles_populator_spec.rb

Line 6 in b2464ff

let(:username_populator) { UsernamesAndRolesPopulator.new(uaa_client) }

maybe there it should also be uaa_username_lookup_client

I've changed the name to uaa_username_lookup_client in the DependencyLocator to incorporate the use case this UAA client is used for (and the permissions it has). And then I've adapted all places where the client is fetched from the DependencyLocator. I did not change other places where it is just a variable holding an instance of class UaaClient. In the end this particular uaa_username_lookup_client would also be used inside UsernamePopulator and UsernamesAndRolesPopulator, but there the longer name would make reading the code more complicated without adding much benefit (i.e. there are not multiple UAA clients involved). I've looked again through the code and would rather keep uaa_client in all the tests where it is just a mock object.

[moleske]

looks good to me. had same question that @kathap but your answer makes sense to me