Add storage-cli Support for AliCloud #4672
Draft
+283
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
spec/unit/lib/cloud_controller/blobstore/storage_cli/storage_cli_client_spec.rb
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds AliCloud (OSS) support to the Cloud Controller when using storage-cli as the blobstore backend.
Introduces AliStorageCliClient, registered under the aliyun provider.
Extends the storage-cli config validation to recognize AliCloud-specific fields:
access_key_id
access_key_secret
endpoint
bucket_name
A short explanation of the proposed change:
Updates Cloud Controller to route Aliyun blobstores through the new storage-cli client.
An explanation of the use cases your change solves
fog-aliyun is outdated — last updated in 2022, with some transitive dependencies dating back to 2015.
This is the Cloud Controller’s side of that migration, ensuring CC can correctly select and use the new storage-cli client for OSS.
Links to any other associated PRs
https://github.com/cloudfoundry/storage-cli
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests