Exclude CLAW from branch protection rule #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI uses CLAW as a redirect for downloads. We use github actions workflows for our release. The workflow updates the repo with latest version number to serve using a bot account. This push is failing because of branch protection rules as seen here. The same action passed when it ran with branch protection rule removed for CLAW. We tested this with multiple different settings (changing user/email/keys and combinations of these), none of them worked with branch protection rules being set.
The ssh key used to access repo belongs to the CF CLI BOT which belongs cloudfoundry/wg-app-runtime-interfaces-cli-bots Discussed this issue in WG Call as well. So the best course of action for now is to remove the branch protection rule. We are doing similar thing with homebrew-tap update from our workflow which has no issues. This repo has no branch protection rule set.