[ARI] Promote Greg Weresch to CLI approvers #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b
force-pushed
the
promote-to-ari-cli-approvers-weresch
branch
from
479a4e3 to
889d2ef
Compare
Gerg
changed the title
|
Per https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-to-reviewer-or-approver, you need 2 existing CLI approvers to review the application to affirm that Greg meets the criteria for promotion. Once the review is complete, Stephan or I can merge this PR. cc @cloudfoundry/wg-app-runtime-interfaces-cli-approvers |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
LGTM - but I can't approve my PR. @Gerg can you please approve this? |
Gerg
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greg demonstrated advanced knowledge in CF CLI, Golang, and software engineering. I propose promoting him to approver.