Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARI] Add Alex Rocha as capi approver #962

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[ARI] Add Alex Rocha as capi approver #962

merged 1 commit into from
Aug 29, 2024

Conversation

xandroc
Copy link
Contributor

@xandroc xandroc commented Aug 29, 2024 •
edited
Loading

@xandroc xandroc changed the title Add Alex Rocha as capi approver Add Alex Rocha as ARI approver Aug 29, 2024
@xandroc xandroc changed the title Add Alex Rocha as ARI approver Add Alex Rocha as capi approver Aug 29, 2024
@Gerg Gerg requested review from Gerg and stephanme August 29, 2024 17:51
@xandroc xandroc changed the title Add Alex Rocha as capi approver [ARI] Add Alex Rocha as capi approver Aug 29, 2024
@Gerg
Copy link
Member

Gerg commented Aug 29, 2024

Per https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-to-reviewer-or-approver, you need 2 existing CAPI approvers to review the application to affirm that you meet the criteria for promotion. Once the review is complete, Stephan or I can merge this PR.

cc @cloudfoundry/wg-app-runtime-interfaces-capi-approvers

tcdowney
tcdowney approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@tcdowney tcdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

moleske
moleske approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! 😉

Thrilled to have you continue contributing!

Gerg
Gerg approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@Gerg Gerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your promotion!

@Gerg Gerg merged commit 6fddd9b into cloudfoundry:main Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moleske moleske moleske approved these changes

@Benjamintf1 Benjamintf1 Benjamintf1 approved these changes

@tcdowney tcdowney tcdowney approved these changes

@Gerg Gerg Gerg approved these changes

@stephanme stephanme Awaiting requested review from stephanme

Assignees
No one assigned
Labels
None yet
Projects
CF Community
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xandroc @Gerg @tcdowney @Benjamintf1 @moleske