Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new repo uaa-ci #970

Merged

Conversation

hsinn0
Copy link
Contributor

@hsinn0 hsinn0 commented Sep 5, 2024

  • To migrate from pivotal org.
  • Giving approver roles only to the current team members with access to secrets that are required to update the pipelines.

- To migrate from `pivotal` org.
- Giving approver roles only to the current team members with access to secrets that are required to update the pipelines.
@hsinn0
Copy link
Contributor Author

hsinn0 commented Sep 5, 2024

Following the instructions given in the Slack thread.

@jpalermo jpalermo requested review from rkoster and beyhan September 6, 2024 03:04
@beyhan beyhan requested review from a team, stephanme, ameowlia and ChrisMcGowan and removed request for a team September 6, 2024 06:17
@beyhan beyhan added the toc label Sep 6, 2024
@ameowlia
Copy link
Member

ameowlia commented Sep 10, 2024

Giving approver roles only to the current team members with access to secrets that are required to update the pipelines.

@hsinn0 - Approver level is not enough to access to github secrets. Github secrets can only be accessed by admin users. If people need admin access, you can create an admin override team like this.

@hsinn0
Copy link
Contributor Author

hsinn0 commented Sep 10, 2024

@hsinn0 - Approver level is not enough to access to github secrets. Github secrets can only be accessed by admin users.

@ameowlia, the secrets here are not Github secrets. They are the ones stored in an internal vault.

@beyhan beyhan merged commit 8bc5d26 into cloudfoundry:main Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants