Pin prometheus and bump other dependencies #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkocher
previously approved these changes
Apr 15, 2024
ctlong
reviewed
Apr 15, 2024
rroberts2222
force-pushed
the
fix/pin-prometheus-and-bump
branch
from
d3b6312
to
b55bf90
Compare
Signed-off-by: Rebecca Roberts <rebecca.roberts@broadcom.com> Signed-off-by: Matthew Kocher <matthew.kocher@broadcom.com>
rroberts2222
force-pushed
the
fix/pin-prometheus-and-bump
branch
from
f0dff71
to
62e78cc
Compare
mkocher
previously approved these changes
Apr 15, 2024
rroberts2222
force-pushed
the
fix/pin-prometheus-and-bump
branch
from
62e78cc
to
072b247
Compare
mkocher
previously approved these changes
Apr 15, 2024
Signed-off-by: Rebecca Roberts <rebecca.roberts@broadcom.com> Signed-off-by: Matthew Kocher <matthew.kocher@broadcom.com>
rroberts2222
force-pushed
the
fix/pin-prometheus-and-bump
branch
from
072b247
to
5f89478
Compare
mkocher
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We attempted to bump to the latest prometheus but ran into many compilation errors. We decided to keep it at the version we are currently using for now by adding the
replacedirective in the go.mod.Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack