Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit all OTel signals by default #609

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

mkocher
Copy link
Member

@mkocher mkocher commented Sep 9, 2024

Description

The OpenTelemetry Collector release now sets up noop pipelines to consume these signals and prevent error messages if no pipelines for the signal have been configured by the operator.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

The OpenTelemetry Collector release now sets up noop pipelines to
consume these signals and prevent error messages if no pipelines for the
signal have been configured by the operator.

Signed-off-by: Carson Long <12767276+ctlong@users.noreply.github.com>
@mkocher mkocher requested a review from a team as a code owner September 9, 2024 21:46
- safe to assume timestamps will be positive or else you've got way
  worse problems

Signed-off-by: Matthew Kocher <matthew.kocher@broadcom.com>
@mkocher mkocher merged commit 5fdaf9c into main Sep 9, 2024
6 checks passed
@mkocher mkocher deleted the emit-all-otel-signals-by-default branch September 9, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants