fix(grpcconnector): Correctly disconnect dopplers (#623)

Previously, implicit memory aliasing meant that we were only disconnecting one doppler connection at a time. I'm unsure what the exact impact of this bug was.
cloudfoundry · Aug 23, 2023 · 10ee009 · 10ee009
1 parent 7f5c5c2
commit 10ee009
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/plumbing/grpc_connector.go b/src/plumbing/grpc_connector.go
@@ -142,6 +142,8 @@ func (c *GRPCConnector) handleFinderEvent(uris []string) {
 	}
 
 	for _, deadClient := range deadClients {
+		deadClient := deadClient
+
 		log.Printf("Disabling reconnects for doppler %s", deadClient.uri)
 		deadClient.disconnect = true
 

diff --git a/src/rlp/internal/ingress/grpc_connector.go b/src/rlp/internal/ingress/grpc_connector.go
@@ -145,6 +145,8 @@ func (c *GRPCConnector) handleFinderEvent(uris []string) {
 	}
 
 	for _, deadClient := range deadClients {
+		deadClient := deadClient
+
 		log.Printf("Disabling reconnects for doppler %s", deadClient.uri)
 		deadClient.disconnect = true