Add cleaner for orphaned files #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanBorislavovDimitrov
requested changes
Nov 27, 2023
| LOGGER.debug(MessageFormat.format(Messages.GETTING_OPERATIONS_STARTED_AFTER_0, oneHourAgo)); | ||
| var operations = operationService.createQuery() | ||
| .startedAfter(oneHourAgo) | ||
| .withMtaIdsIn(List.copyOf(fileIds)) |
There was a problem hiding this comment.
File ID is the same as the MTA ID?
There was a problem hiding this comment.
Oops, this was a leftover from when the code assumed the operations had a relation to the files.
Removed
...s/src/main/java/org/cloudfoundry/multiapps/controller/process/jobs/OrphanedFilesCleaner.java
Show resolved
Hide resolved
...s/src/main/java/org/cloudfoundry/multiapps/controller/process/jobs/OrphanedFilesCleaner.java
Show resolved
Hide resolved
...s/src/main/java/org/cloudfoundry/multiapps/controller/process/jobs/OrphanedFilesCleaner.java
Show resolved
Hide resolved
| LOGGER.debug(Messages.NO_ORPHANED_FILES_TO_DELETE); | ||
| return; | ||
| } | ||
| LOGGER.debug(MessageFormat.format(Messages.DELETING_ORPHANED_FILES_0, fileIdsToFiles.keySet())); |
There was a problem hiding this comment.
Log how many files are deleted
...s/src/main/java/org/cloudfoundry/multiapps/controller/process/jobs/OrphanedFilesCleaner.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/cloudfoundry/multiapps/controller/process/jobs/OrphanedFilesCleaner.java
Outdated
Show resolved
Hide resolved
Delete files that have no started operation within the last hour LMCROSSITXSADEPLOY-2714
IvanBorislavovDimitrov
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete files that have no started operation within the last hour
LMCROSSITXSADEPLOY-2714