Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update optional services to don't fail sometimes #1411

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Update optional services to don't fail sometimes #1411

merged 1 commit into from
Jan 16, 2024

Conversation

Yavor16
Copy link
Contributor

@Yavor16 Yavor16 commented Jan 6, 2024

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 6, 2024 •
edited
Loading

CLA Missing ID CLA Not Signed

@IvanBorislavovDimitrov
Copy link
Contributor

Do not forget to squash some of the commits

ikasarov
ikasarov requested changes Jan 12, 2024
View reviewed changes
...cess/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/SyncFlowableStep.java Outdated Show resolved Hide resolved
...controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/Messages.java Outdated Show resolved Hide resolved
...ess/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/CreateServiceStep.java Outdated Show resolved Hide resolved
...r-process/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/ServiceStep.java Outdated Show resolved Hide resolved
...cess/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/SyncFlowableStep.java Outdated Show resolved Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/steps/UpdateServiceMetadataStep.java Outdated Show resolved Hide resolved
...controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/Messages.java Outdated Show resolved Hide resolved
@Yavor16 Yavor16 requested a review from ikasarov January 12, 2024 13:08
@Yavor16 Yavor16 force-pushed the failing-optional-service-update branch from 5bbdf37 to 98e3c99 Compare January 16, 2024 15:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

5.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Yavor16 Yavor16 merged commit 14cd33c into master Jan 16, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanBorislavovDimitrov IvanBorislavovDimitrov IvanBorislavovDimitrov approved these changes

@ikasarov ikasarov ikasarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yavor16 @IvanBorislavovDimitrov @ikasarov