Do not always print service is optional during failure#1428
Merged
Conversation
Contributor
|
instead of having the condition in every step can you extract it in: You can have 2 types of messages: This way in the steps Update,CreateService, etc, you're just throwing the exception and its message will be added. Thus you will not have the code duplication |
Yavor16
force-pushed
the
fix-fail-service-creation-message
branch
2 times, most recently
from
5ffb76f to
bea83b5
Compare
...r-process/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/ServiceStep.java
Outdated
Show resolved
Hide resolved
Yavor16
force-pushed
the
fix-fail-service-creation-message
branch
from
bea83b5 to
aa08cb6
Compare
Yavor16
force-pushed
the
fix-fail-service-creation-message
branch
from
aa08cb6 to
414a70a
Compare
|
IvanBorislavovDimitrov
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMCROSSITXSADEPLOY-2878