Add spec file example for "performRpInitiatedLogout" #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
peterhaochen47
commented
Nov 17, 2023
peterhaochen47
commented
- a new oidc/oauth provider config "performRpInitiatedLogout" is added in Add config to control whether to perform "OpenID Connect RP-Initiated Logout" when using an external OIDC provider uaa#2590
- this repo only requires an addition in the example config provided in the spec file (since uaa-release passes through the oauth/oidc provider config to uaa server verbatim, so no new translation logic required when adding a new config on this layer)
- add the field to tests
- This PR fixes No config to turn off "OpenID Connect RP-Initiated Logout" when using an external OIDC provider #701
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186507325 The labels on this github issue will be updated when the story is started. |
peterhaochen47
force-pushed
the
pr/develop/add-performRpInitiatedLogout
branch
from
f13dbde
to
d4103fe
Compare
swalchemist
reviewed
Nov 17, 2023
| @@ -1077,6 +1078,7 @@ properties: | |||
| skipSslValidation: false | |||
| storeCustomAttributes: true | |||
| passwordGrantEnabled: false | |||
| performRpInitiatedLogout: true | |||
There was a problem hiding this comment.
The default is true, right?
swalchemist
approved these changes
Nov 17, 2023
strehle
approved these changes
Nov 20, 2023
- a new oidc/oauth provider config "performRpInitiatedLogout" is added in cloudfoundry/uaa#2590 - this repo only requires an addition in the example config provided in the spec file (since uaa-release passes through the oauth/oidc provider config to uaa server verbatim, so no new translation logic required when adding a new config on this layer) - add the field to tests [#184752215]
peterhaochen47
force-pushed
the
pr/develop/add-performRpInitiatedLogout
branch
from
d4103fe
to
42a3968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.