Skip to content

Commit

Permalink
exclude vulnerable indirect dep xalan
Browse files Browse the repository at this point in the history
- a vulnerable xalan version (2.7.2; CVE-2022-34169) is brought in by the saml library we use:
org.springframework.security.extensions:spring-security-saml2-core which
has reached EOL (we are replacing it for develop branch, but not 74.5.x
branch). So this xalan would not be bumped by spring-security-saml2-core
anymore.
- so to address this CVE scan result (CVE-2022-34169), exclude this
  indirect dep, like develop branch does: 061bee9
- note: excluding a dep of a library we use carries the risk of failure
  if we trigger a code path in the library that depends on the dep. The
  fact all tests are passing + the fact that this exclude has been applied in develop
  branch for more than 1 year give us enough confidence that this
  exclude would not introduce a failure.

[#186948853]
  • Loading branch information
peterhaochen47 committed Jan 31, 2024
1 parent c9b2b8a commit 05bea28
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions server/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ dependencies {
}
implementation(libraries.springSecuritySaml) {
exclude(module: "bcprov-ext-jdk15on")
exclude(module: "xalan") // exclude vulnerable xalan 2.7.2 (see: CVE-2022-34169)
}
implementation(libraries.springSessionJdbc)

Expand Down
4 changes: 3 additions & 1 deletion uaa/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ dependencies {
testImplementation(libraries.springTest)
testImplementation(libraries.springSecurityJwt)
testImplementation(libraries.springSecurityLdap)
testImplementation(libraries.springSecuritySaml)
testImplementation(libraries.springSecuritySaml) {
exclude(module: "xalan") // exclude vulnerable xalan 2.7.2 (see: CVE-2022-34169)
}
testImplementation(libraries.springSecurityTest)
testImplementation(libraries.mockito)
testImplementation(libraries.tomcatJdbc)
Expand Down

0 comments on commit 05bea28

Please sign in to comment.