Rework: remove setType call from assertThatIllegalArgumentException l…

…ambda in ScimUserTests.testPhoneNumber
cloudfoundry · Mar 15, 2024 · 5e89664 · 5e89664
1 parent 02bd32b
commit 5e89664
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/model/src/test/java/org/cloudfoundry/identity/uaa/scim/ScimUserTests.java b/model/src/test/java/org/cloudfoundry/identity/uaa/scim/ScimUserTests.java
@@ -452,10 +452,11 @@ public void testPhoneNumber() {
         ScimUser user = new ScimUser();
         user.setPhoneNumbers(Collections.singletonList(p1));
 
-        assertThatIllegalArgumentException().isThrownBy(() -> {
-            p1.setType(null);
-            user.addPhoneNumber(p1.getValue());
-        });
+        // should reject adding duplicate phone number if the existing has a type set to null
+        p1.setType(null);
+        assertThatIllegalArgumentException()
+                .isThrownBy(() -> user.addPhoneNumber(p1.getValue()))
+                .withMessageStartingWith("Already contains phoneNumber");
     }
 
     @Test