comment about internal and external client auth

cloudfoundry · Oct 17, 2023 · 7d19c85 · 7d19c85
1 parent be41362
commit 7d19c85
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...ava/org/cloudfoundry/identity/uaa/authentication/ClientDetailsAuthenticationProvider.java b/...ava/org/cloudfoundry/identity/uaa/authentication/ClientDetailsAuthenticationProvider.java
@@ -77,7 +77,7 @@ protected void additionalAuthenticationChecks(UserDetails userDetails, UsernameP
                         break;
                     }
                 } else if (ObjectUtils.isEmpty(authentication.getCredentials())) {
-                    // set none as client_auth_method for all usage of empty secrets, e.g. cf client
+                    // set internally empty as client_auth_method e.g. cf client
                     setAuthenticationMethod(authentication, CLIENT_AUTH_EMPTY);
                 }
                 if (uaaClient.getPassword() == null) {

diff --git a/server/src/main/java/org/cloudfoundry/identity/uaa/oauth/UaaTokenServices.java b/server/src/main/java/org/cloudfoundry/identity/uaa/oauth/UaaTokenServices.java
@@ -491,6 +491,7 @@ private CompositeToken createCompositeToken(String tokenId,
 
     private static Map<String, Object> addRootClaimEntry(Map<String, Object> additionalRootClaims, String entry, String value) {
         Map<String, Object> claims = additionalRootClaims != null ? additionalRootClaims : new HashMap<>();
+        // set externally none as client_auth_method if internally empty
         claims.put(entry, CLIENT_AUTH_EMPTY.equals(value) ? CLIENT_AUTH_NONE : value);
         return claims;
     }