Skip to content

Commit

Permalink
fix: a test certtificate end marker
Browse files Browse the repository at this point in the history
- It is supposed to have 5 `-`s, but one of the test cert value had only 4 `-`s.
- Previous version of `bc-java` did not check for ending `-----` but now it does. See `PemReader.java` change in [the commit](bcgit/bc-java@5ca7b06].
- I did not find any mentioning to this specifc change in BouncyCastle release notes, so it appears to be undocumented change.

[#187388114]
  • Loading branch information
hsinn0 authored and Tallicia committed Apr 19, 2024
1 parent 251fa88 commit 88882b6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public static void addProvider() {
"PwMhO0+dASJ83e2Bu63pKO808BrVjD51sSEMb0qwFc5IV6RzK/mkJgO0fphhoqOm\n" +
"ZLzGcSYwCmj0Vc0GO5NgnFVZg4N9CyYCpDMeQynumlrNhRgnZRzlqXtQgL2bQDiu\n" +
"coxNL/KY05iVlE1bmq/fzNEmEi2zf3dQV8CNSYs=\n" +
"-----END CERTIFICATE----\n";
"-----END CERTIFICATE-----\n";

// openssl req -out cert.pem -nodes -keyout private.key -newkey rsa:2048 -new -x509
public static final String opensslCert = "-----BEGIN CERTIFICATE-----\n" +
Expand Down

0 comments on commit 88882b6

Please sign in to comment.