integrationTest: Add IT for user_token grant variants #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/184429062 The labels on this github issue will be updated when the story is started. |
strehle
changed the title
|
Can we get a description on what this is addressing? |
created it to better understand what #2193 changes, so if we proceed with it, this test should be merged |
swalchemist
reviewed
Aug 2, 2023
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/UserTokenGrantIT.java
Show resolved
Hide resolved
swalchemist
reviewed
Aug 2, 2023
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/UserTokenGrantIT.java
Show resolved
Hide resolved
swalchemist
reviewed
Aug 2, 2023
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/UserTokenGrantIT.java
Outdated
Show resolved
Hide resolved
The grant is similar to refresh but always without a secret. The 4 examples are for the discussion about issue #2193
strehle
changed the title
Closed
strehle
added
the
expected behavior
swalchemist
approved these changes
Aug 10, 2023
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/UserTokenGrantIT.java
Outdated
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/UserTokenGrantIT.java
Outdated
Show resolved
Hide resolved
swalchemist
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Add IT for user_token grant * add more examples for user_token grant The grant is similar to refresh but always without a secret. The 4 examples are for the discussion about issue #2193 * refactor test cases * test renamed * review Co-authored-by: Bruce Ricard <bricard@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Token Grant Type is proprietary grant type. Until now we dont have pure integration tests. therefore add with this PR one.
https://docs.cloudfoundry.org/api/uaa/version/76.18.0/index.html#user-token-grant
In PR
#2193
I noticed that no integration test has to be change but the PR is a restriction of current behavior
Because of the other PR I named the tests according to client types, e.g. public and/or confidential. A public client is a client without any secret or with an empty secret (like cf client). A confidential client is a client with a secure secret.