feature: Store client authentication method in JWT #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: UAA historical supported only secret based client authentication, so no need to have this information on client side. No there is a public usage, later private_key_jwt should be supported. Maybe then tls_client_auth.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185462863 The labels on this github issue will be updated when the story is started. |
strehle
changed the title
...n/java/org/cloudfoundry/identity/uaa/authentication/ClientDetailsAuthenticationProvider.java
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/oauth/UaaTokenServicesTests.java
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/oauth/UaaTokenServicesTests.java
Outdated
Show resolved
Hide resolved
adrianhoelzl-sap
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: UAA historical supported only secret based client authentication, so no need to have this information on client side.
UAA supports until now client_secret_basic and client_secret_post from section 9 of standard:
See: https://openid.net/specs/openid-connect-core-1_0.html#ClientAuthentication
Now there is the public usage, later private_key_jwt should be supported. Maybe then tls_client_auth.
Because of the support of other client authentication methods, the information might be needed or at least helpful for clients.
To be compatible. We add this information only if another (new) authentication was used. New means public and later private_key_jwt. So the new claim in token will only appear if a new method was used.
This PR should serve for solving
-> need to know if public
-> clients should see if private_key_jwt